[PATCH] D39208: [Analyzer] Do not use static storage to for implementations created in BodyFarm.cpp

Devin Coughlin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 23 16:52:52 PDT 2017


dcoughlin added a comment.

I think a good strategy is to look at your diffs and consider whether the benefits of normalizing the style outweigh the cost of losing the history. In this case, I think keeping the history makes sense. (Imagine you are a future maintainer and want to know when and why a new option was added. Is is very helpful to use git annotate to understand why the code is the way it is.)


https://reviews.llvm.org/D39208





More information about the cfe-commits mailing list