[PATCH] D39208: [Analyzer] Do not use static storage to for implementations created in BodyFarm.cpp

Devin Coughlin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 23 16:15:47 PDT 2017

dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.

Content-wise, LGTM. There is a style nit inline.

Also, can you avoid reformatting the lines that haven't changed? This will help preserve the history of the file and make it clear what changes are related to your intended change in functionality.

Comment at: lib/Analysis/AnalysisDeclContext.cpp:308
+BodyFarm *AnalysisDeclContextManager::getBodyFarm() {
+  if (BdyFrm == nullptr)
+    BdyFrm = new BodyFarm(ASTCtx, Injector.get());
Nit: Style-wise this is idiomatically written as:
if (!BdyFrm)


More information about the cfe-commits mailing list