[PATCH] D39069: CodeGen: Fix missing debug loc due to alloca

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 23 15:26:38 PDT 2017

rjmccall added a comment.

The code looks fine to me.  The test seems very vague to me, but I'd like Dave to weigh in on that, because I'm not sure it's reasonable to test the exact pattern here.

Also, Dave, I don't know what the IR invariants around debug info are.  Is this something we should be updating all of our uses of saveIP() to do if there's a possibility of emitting arbitrary code while the IP is saved?


More information about the cfe-commits mailing list