[PATCH] D39069: CodeGen: Fix missing debug loc due to alloca

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 23 11:22:25 PDT 2017

yaxunl added a comment.

In https://reviews.llvm.org/D39069#903344, @rjmccall wrote:

> If this is something we generally need to be doing in all the places we temporarily save and restore the insertion point, we should fix the basic behavior of saveIP instead of adding explicit code to a bunch of separate places.  Can we just override saveIP() on CGBuilder to return a struct that also includes the current debug location?

IRBuilderBase::InsertPointGuard does that. Will use it instead.


More information about the cfe-commits mailing list