[PATCH] D39178: [rename] support renaming class member.

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

Lgtm. Nice!



================
Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:251
+      // Ignore implicit initializers.
+      if (!Initializer->isWritten())
+        continue;
----------------
Is there a test case for this?


================
Comment at: unittests/Rename/RenameMemberTest.cpp:206
+
+      X::X():a() {}
+      )";
----------------
Maybe add one more field in the test?


https://reviews.llvm.org/D39178