[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 23 01:04:43 PDT 2017

rjmccall added a comment.

Hmm.  I'm not sure I like the design of merging TBAAAccessInfo into LValueBaseInfo.  LValueBaseInfo is currently the set of information that's generally preserved across l-value manipulations.  It was extracted from LValue specifically to create an encapsulated entity that can just be mindlessly propagated in most of that code.  But if you merge TBAA information into it, then l-value manipulations need to be aware of its contents, in the same way they have to be aware of everything else they're storing in the new LValue.  The fact that code needs to be aware of it suggests it should continue to be an explicit argument, or at the very least be combined with something else that l-value manipulations generally already need to be aware of, like the type.


More information about the cfe-commits mailing list