[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware updated this revision to Diff 119576.
baloghadamsoftware added a comment.
Herald added a subscriber: szepet.

I think it is the final attempt. If Symbols are different, the type is extended, so we store a correct (but extended) range. However, if the Symbols are the same, we do not change the type so checks like `assumeInbound()` are not affected.

Anna, Devin, Artem, please review it whether this version is functionally correct. (Style is another thing.) If not, then we should go back to the local solution in the iterator checkers. However, we must continue the review there, it is standing still for half a year.


https://reviews.llvm.org/D35109

Files:
  lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
  test/Analysis/std-c-library-functions.c
  test/Analysis/svalbuilder-rearrange-comparisons.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35109.119576.patch
Type: text/x-patch
Size: 41543 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171019/51776df9/attachment-0001.bin>