[PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

[Nico Weber via Phabricator via cfe-commits]

thakis added inline comments.


================
Comment at: cfe/trunk/lib/Sema/SemaDecl.cpp:5650
+          NewImportAttr->getRange(), S.Context,
+          NewImportAttr->getSpellingListIndex()));
+    } else {
----------------
NewImportAttr can be nullptr here, at least for invalid code. This change introduced https://bugs.llvm.org/show_bug.cgi?id=34981 , please take a look.


Repository:
  rL LLVM

https://reviews.llvm.org/D18953