Patch bug 27628 (clang-tidy should exit with a failure code when there are errors)

Friedman, Eli via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 17 12:10:32 PDT 2017


Sometimes people just lose track; "pinging" is normal (see 
http://llvm.org/docs/DeveloperPolicy.html#code-reviews).  And sometimes 
it's helpful to CC reviewers in the area; adding Alexander Kornienko.

-Eli

On 10/17/2017 12:03 PM, Antoni Boucher wrote:
> Since the patch was redirected to the right mailing list and the subject
> was edited, I believe everything is okay, now?
> Is there any news?
> Thanks.
>
> On Thu, Sep 28, 2017 at 06:56:57PM +0000, Friedman, Eli wrote:
>
>> When you're submitting a patch, please make sure you're sending it to 
>> the right list, and the "subject" line actually describes what the 
>> patch changes; otherwise, reviewers won't notice the patch.  
>> Optionally, you can submit a patch using Phabricator, a tool which 
>> which makes patch reviews a little easier.  See 
>> http://llvm.org/docs/DeveloperPolicy.html#code-reviews
>>
>> -Eli
>>
>> On 9/28/2017 10:22 AM, Antoni Boucher via cfe-commits wrote:
>>
>>> Any news on this?
>>>
>>>> Aaand the patch itself...
>>>>
>>>> -K
>>>>
>>>> On 9/8/2017 10:32 AM, Krzysztof Parzyszek via cfe-commits wrote:
>>>>
>>>>> This should to to cfe-commits. Redirecting.
>>>>>
>>>>> -Krzysztof
>>>>>
>>>>> On 9/8/2017 10:25 AM, Antoni Boucher via llvm-commits wrote:
>>>>>
>>>>>> Hello. I've fixed the bug 27628: 
>>>>>> https://bugs.llvm.org/show_bug.cgi?id=27628
>>>>>>
>>>>>> I attached the patch.
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>>
>>>>>> _______________________________________________ llvm-commits 
>>>>>> mailing list llvm-commits at lists.llvm.org 
>>>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>>>
>>>>
>>>>
>>>> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora 
>>>> Forum, hosted by The Linux Foundation -------------- next part 
>>>> -------------- An embedded and charset-unspecified text was 
>>>> scrubbed... Name: clang-tidy-error-code.diff URL: 
>>>> <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170908/8a2 
>>>> 98102/attachment.ksh>
>>>
>>> _______________________________________________ cfe-commits mailing 
>>> list cfe-commits at lists.llvm.org 
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>>
>> -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation 
>> Center, Inc. is a member of Code Aurora Forum, a Linux Foundation 
>> Collaborative Project
>>

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project



More information about the cfe-commits mailing list