[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 17 00:43:52 PDT 2017


sammccall accepted this revision.
sammccall added a comment.

So I'm not totally convinced that treating an abrupt exit or EOF as an error is worth the hassle (others might disagree), but it's certainly reasonable.
Could you add a test for the new behavior?
something like

RUN: not clangd -run-synchronously < %s
<initialize and exit (no shutdown)>

RUN: not clangd -run-synchronously < %s
<initialize, and nothing else (stdin will just get eof)>


https://reviews.llvm.org/D38939





More information about the cfe-commits mailing list