[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

John Baldwin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 16 21:55:14 PDT 2017


bsdjhb marked 2 inline comments as done.
bsdjhb added inline comments.


================
Comment at: src/UnwindRegistersSave.S:100
+#
+DEFINE_LIBUNWIND_FUNCTION(unw_getcontext)
+  .set push
----------------
sdardis wrote:
> After looking at another implementation of libunwind and the other platforms that are supported, it seems to me that we need to save all the registers.
I was about to ask if that would be better as well.


https://reviews.llvm.org/D38110





More information about the cfe-commits mailing list