[PATCH] D38979: Fix usage in TableGen of getValueAsString

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 16 14:49:48 PDT 2017


erichkeane created this revision.

Record::getValueAsString returns a stringref to an interned
string (apparently had been changed since most of tablegen was
written).  In this patch, I audited the usage of getValueAsString
to find places where we can trivially stop storing 'std::string' and instead
keep the stringref.

There was one instance where an unnecessary 'stringstream' was being used,
so that has been removed as well to unblock the stringref replacing string fix.


https://reviews.llvm.org/D38979

Files:
  utils/TableGen/ClangAttrEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38979.119218.patch
Type: text/x-patch
Size: 6523 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171016/b48a0b55/attachment.bin>


More information about the cfe-commits mailing list