[PATCH] D38969: Sort Attributes by "HeaderName"

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 16 12:30:10 PDT 2017


erichkeane added inline comments.


================
Comment at: utils/TableGen/ClangAttrEmitter.cpp:3670
+  DocumentationData(const Record &Documentation, const Record &Attribute,
+                    const std::pair<std::string, unsigned> &&HeadingAndKinds)
+      : Documentation(&Documentation), Attribute(&Attribute),
----------------
Craig brought up that I could just take by value and move out of 'first', which is more flexible for usage.  New patch incoming once it passes a build.


https://reviews.llvm.org/D38969





More information about the cfe-commits mailing list