[PATCH] D38704: [libunwind] Emulate pthread rwlocks via SRW locks for windows

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 15 03:48:48 PDT 2017

mstorsjo added a comment.

In https://reviews.llvm.org/D38704#897935, @majnemer wrote:

> I don't think we should depend on LLVM for the locking stuff. This sort of infrastructure is in the same bucket as the demangler which we haven't really solved.
> I *do* find it weird to do it this way though. I think you should have some mutex functions which include read/write unlock. This way you don't need the weird state.

Ok, sure. I can add a new class with an API similar to the one in LLVM, but only the bare essentials (i.e. exactly what libunwind has got right now, plus SRW locks for windows) for now.


More information about the cfe-commits mailing list