[PATCH] D38883: [CMake][OpenMP] Customize default offloading arch

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 13 11:25:29 PDT 2017


tra added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.h:90
-  }
 };
 
----------------
gtbercea wrote:
> gtbercea wrote:
> > I would also like to keep the spirit of this code if not in this exact form at least something that performs the same functionality.
> @tra what's your opinion on this code? Should this stay, stay but modified to be more robust or taken out completely?
There are currently no users for this. In general, I would rather not have magically-changing default GPU based on how broken your CUDA installation is. IMO it would be better to keep defaults static and fail if prerequisites are not met.


https://reviews.llvm.org/D38883





More information about the cfe-commits mailing list