[PATCH] D38816: Convert clang::LangAS to a strongly typed enum
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 13 08:38:37 PDT 2017
Anastasia added inline comments.
Comment at: lib/AST/TypePrinter.cpp:1323
OS << "address_space(";
- OS << T->getEquivalentType().getAddressSpace();
+ OS << T->getEquivalentType()
> Anastasia wrote:
> > Why do we need this change?
> `__attribute__((address_space(n)))` is a target address space and not a language address space like `LangAS::opencl_generic`. Isn't `Qualifiers::getAddressSpaceAttributePrintValue()` meant exactly for this use case?
Yes, I think there are some adjustment we do in this method to get the original source value to be printed corerctly. Does this mean we have no tests that caught this issue?
More information about the cfe-commits