[PATCH] D38861: [CodeGen] Error on unsupported checked multiplies early

Joerg Sonnenberger via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 12 18:32:19 PDT 2017

joerg added inline comments.

Comment at: lib/CodeGen/CGBuiltin.cpp:2263
+      }
+    }
vsk wrote:
> rjmccall wrote:
> > Is there a reason this only fails on x86?  If LLVM doesn't have generic wide-operation lowering, this probably needs to be a target whitelist rather than a blacklist.
> That makes sense. For the 128-bit operation, the whitelist is {x86-64, wasm64, mips64}. We don't support this operation for bit widths larger than 128 bits on any target. I'll update the patch accordingly.
That sounds wrong. __int128_t should be supported by all 64bit architectures, not just those three.


More information about the cfe-commits mailing list