[PATCH] D38859: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 12 17:29:06 PDT 2017

vsk added a comment.

In https://reviews.llvm.org/D38859#896517, @alexshap wrote:

> yeah, i agree, this is not a good idea. My thoughts were different - right now it's not particularly convenient that one has to specify LLVM_PROFDATA when it's not actually used by the build.
>  Maybe we can create the target "generate-profdata" only if LLVM_PROFDATA is set (but don't fail otherwise) ?

+ 1, sgtm



More information about the cfe-commits mailing list