[PATCH] D38861: [CodeGen] Error on unsupported checked multiplies early

[Vedant Kumar via Phabricator via cfe-commits]

vsk added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:2263
+      }
+    }
+
----------------
rjmccall wrote:
> Is there a reason this only fails on x86?  If LLVM doesn't have generic wide-operation lowering, this probably needs to be a target whitelist rather than a blacklist.
That makes sense. For the 128-bit operation, the whitelist is {x86-64, wasm64, mips64}. We don't support this operation for bit widths larger than 128 bits on any target. I'll update the patch accordingly.


https://reviews.llvm.org/D38861