[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 12 15:22:35 PDT 2017

On 12 October 2017 at 15:11, Roman Lebedev via Phabricator via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> lebedev.ri reopened this revision.
> lebedev.ri added a comment.
> This revision is now accepted and ready to land.
> Reverted due to http://bb9.pgr.jp/#/builders/20/builds/59 that i don't
> currently know how to deal with.
> It is really sad that i failed to encounter it during testing.

I see three issues there:

1) A warning in this code due to missing parentheses around a ^ operator.
2) This code generating correct warnings in the libc++ test suite. You
could ask EricWF (cc'd) to look at those and either fix them or turn the
warning flag off for libc++'s tests.
3) A stage2 / stage3 comparison failure in CGAtomic.cpp. That's
pre-existing and nothing to do with your change.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171012/38236154/attachment.html>

More information about the cfe-commits mailing list