[PATCH] D38840: [compiler-rt] [cmake] [asan] Reuse generate_asan_tests for dynamic tests
George Karpenkov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 12 10:15:33 PDT 2017
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
@mgorny so this one actually changes semantics.
The previous one reused generated object files, and with the change it will start recompiling all the tests again.
(and actually being able to export object files has added quite a bit of complexity to all these compiler-rt macros).
The current code also looks weird, because it depends on `ASAN_INST_TEST_OBJECTS`, but will actually recompile and export them.
I think a better fix would be to change `add_compiler_rt_test` to accept two kinds of dependencies (probably again `DEPS` and `COMPILE_DEPS`? I know the name is not very descriptive, but I've kept it from the previous version).
It already checks that variable to conditionally add `clang` to dependencies.
More information about the cfe-commits