[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 12 01:56:05 PDT 2017

NoQ added a comment.

Ideas behind both hashing change and new testing mechanism look great to me.

I think it would be great to split them into two different patches, to be able to easily see how the change in the hashing affects the tests (and maybe revert easily if something goes wrong).

Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:88
+                &ExprInspectionChecker::analyzerNumTimesReached)
+          .Case("clang_analyzer_hash_dump",
+                &ExprInspectionChecker::analyzerDumpHash)
`clang_analyzer_hashDump` would be more consistent.


More information about the cfe-commits mailing list