[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 12 01:34:27 PDT 2017

rjmccall added a comment.

In https://reviews.llvm.org/D35082#895312, @yaxunl wrote:

> Thanks. I will separate the implicit addr space flag to another patch.

Thanks, appreciated.

Comment at: include/clang/AST/Type.h:562
+  static const uint32_t IMask = 0x200;
+  static const uint32_t IShift = 9;
   static const uint32_t AddressSpaceMask =
yaxunl wrote:
> rjmccall wrote:
> > "I" is not an appropriate abbreviation for "AddressSpaceImplicit".
> Will change it to ImplictAddrSpace.
Sounds good.


More information about the cfe-commits mailing list