[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

Justin Lebar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 11 13:26:51 PDT 2017

jlebar added a comment.

My only regret is that I have but one +1 to give to this patch.

Comment at: include/clang/Basic/AddressSpaces.h:51
+namespace LanguageAS {
 /// The type of a lookup table which maps from language-specific address spaces
I wonder if you need this namespace?  LangAS right next to LanguageAS reads strangely to me -- "what's the difference?".

I guess you'd need to rename Map and fromTargetAS, but the other two members are probably OK?



More information about the cfe-commits mailing list