[PATCH] D37856: [refactor] add support for refactoring options

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 11 06:37:30 PDT 2017

hokein added a comment.

Sorry for the delay. I saw you have reverted this commit somehow. A post commit.

Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113
-        SymbolSelectionRequirement()));
+        SymbolSelectionRequirement(), OptionRequirement<NewNameOption>()));
     return Rules;
Thought it a bit more: it requires all of the requirements are satisfied, I think we need to support "one-of" option. For example,  we have two option "-a" and "-b",  only one of them is allowed to be present at the same time.



More information about the cfe-commits mailing list