[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 11 05:41:03 PDT 2017


martong added inline comments.


================
Comment at: test/Analysis/bug_hash_test.cpp:105
+void g() {
+  TX<int> x;
+  TX<long> xl;
----------------
As we discussed, the checking of the equality of the `IssueString` in case of `TX<int>` and `TX<double>` is implicit. And as such it is hard to see that it is really tested. Perhaps a comment here could indicate this implicit checking mechanism.


https://reviews.llvm.org/D38728





More information about the cfe-commits mailing list