[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width
Anna Zaks via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 10 23:20:47 PDT 2017
zaks.anna accepted this revision.
zaks.anna added a comment.
Once the comments by @paquette are addressed, LGTM. Thanks!
Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:138
+ OS << " larger or equal to the width of type '"
+ << B->getLHS()->getType().getAsString() << "'.";
> Maybe "greater than or equal to" instead of "larger or equal to" just for convention? I hear/read that more often, so seeing "larger" is a little weird.
> Minor point though, so if it makes the message too long it doesn't matter.
I agree that "greater than or equal to" is better, so let's change to that.
More information about the cfe-commits