[PATCH] D38599: Remove warnings for dynamic_cast fallback.
Jonathan Roelofs via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 10 17:23:07 PDT 2017
jroelofs added a comment.
In https://reviews.llvm.org/D38599#893990, @jroelofs wrote:
> In https://reviews.llvm.org/D38599#893985, @danalbert wrote:
> > In https://reviews.llvm.org/D38599#893903, @jroelofs wrote:
> > > That reminds me... this does need a testcase or two.
> > Oh, also, any test I add is going to fail, since the case I'm trying to account for here is not the default behavior.
> That's what an `available_feature` + `// REQUIRES:` is for.
Which should be set (along with -D_LIBCXX_DYNAMIC_FALLBACK (possibly renamed to _LIBCXXABI_DYNAMIC_FALLBACK)) via a CMake flag... We shouldn't just be defining macros like this in CMAKE_CXX_FLAGS.
More information about the cfe-commits