[PATCH] D38599: Remove warnings for dynamic_cast fallback.

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 9 14:46:26 PDT 2017

Quuxplusone added a comment.

I'm also much out of my depth here, but I'm skeptical. You're changing the comments in the code from essentially saying "This workaround helps people with broken code" to essentially saying "This indispensable functionality helps people like me who use dlopen()."  Are you 100% sure that you're not just a person with broken code?

In other words, what did this guy from 2013 get wrong? -- or, if "he got nothing wrong", then why can't you just follow his advice to eliminate the duplicate typeinfos from your code? http://www.russellmcc.com/posts/2013-08-03-rtti.html



More information about the cfe-commits mailing list