[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 9 10:03:41 PDT 2017

ilya-biryukov added a comment.

We had a discussion with @sammccall  offline, probably

> - what's the goal? Make the code read more naturally, change the async model, or something else?

Callback API is more flexible (if `std::future` that we use had `then`, they'd be equivalent).
We have internal clients that want to be notified about results of code completion without

> - what's the end state for codeComplete specifically? will we switch to the new overload and delete the other, or is `makeFutureAPIFromCallback` here to stay?

I think the way to go would be exactly that, switch to the new API and remove the older one. There are usages in tests, `ClangdLSPServer` and in our internal client, but I'll remove them with a separate commit later.
Added a deprecation notice for the API.


More information about the cfe-commits mailing list