[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 9 01:42:27 PDT 2017

sammccall added a comment.

I'm missing some context for this one:

- what's the goal? Make the code read more naturally, change the async model, or something else?
- what's the end state for codeComplete specifically? will we switch to the new overload and delete the other, or is makeFutureAPIFromCallback here to stay?


More information about the cfe-commits mailing list