[PATCH] D38596: Implement attribute target multiversioning

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 9 08:29:26 PDT 2017

erichkeane added a subscriber: rsmith.
erichkeane added a comment.

In https://reviews.llvm.org/D38596#891603, @aaron.ballman wrote:

> The attribute and sema bits look good to me, but I agree that you might want Richard's opinions before committing.

Oh, definitely!  I actually put this up for @echristo to take a look at as a sanity check.  I realized it was a big patch so didn't want to spam a bunch of people.  @rsmith was definitely on the list!  I'll get this last const-auto fix (FWIW, I'm seeing the benefits now of for (X: Xs) being the same as for (const auto &&X : Xs)...) and add him and @rnk to start doing this as a 'final' review.

Thank you very much @echristo, @hfinkel  and @aaron.ballman !


More information about the cfe-commits mailing list