[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri updated this revision to Diff 118143.
lebedev.ri added a comment.

Rework `AnalyzeComparison()` and `DiagnoseOutOfRangeComparison()` - avoid that fast-return path in `DiagnoseOutOfRangeComparison()`
`AnalyzeComparison()` is now a bit smarter, and it

1. calls `CheckTautologicalComparison()`
2. returns if it diagnosed anything
3. else, calls `DiagnoseOutOfRangeComparison()`
4. returns if it diagnosed anything.

`check-clang-sema` and `check-clang-semacxx` are good.
Stage-2 build still good.


Repository:
  rL LLVM

https://reviews.llvm.org/D38101

Files:
  docs/ReleaseNotes.rst
  include/clang/Basic/DiagnosticGroups.td
  include/clang/Basic/DiagnosticSemaKinds.td
  lib/Sema/SemaChecking.cpp
  test/Sema/outof-range-constant-compare.c
  test/Sema/tautological-constant-compare.c
  test/Sema/tautological-unsigned-zero-compare.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38101.118143.patch
Type: text/x-patch
Size: 42276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171007/572038a7/attachment-0001.bin>