r315107 - [MS] Raise the default value of _MSC_VER to 1911, which is VS 2017

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 6 14:02:28 PDT 2017


Author: rnk
Date: Fri Oct  6 14:02:28 2017
New Revision: 315107

URL: http://llvm.org/viewvc/llvm-project?rev=315107&view=rev
Log:
[MS] Raise the default value of _MSC_VER to 1911, which is VS 2017

Summary:
This raises our default past 1900, which controls whether char16_t is a
builtin type or not.

Implements PR34243

Reviewers: hans

Subscribers: STL_MSFT, rsmith, cfe-commits

Differential Revision: https://reviews.llvm.org/D38646

Modified:
    cfe/trunk/docs/ReleaseNotes.rst
    cfe/trunk/lib/Driver/ToolChains/MSVC.cpp

Modified: cfe/trunk/docs/ReleaseNotes.rst
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ReleaseNotes.rst?rev=315107&r1=315106&r2=315107&view=diff
==============================================================================
--- cfe/trunk/docs/ReleaseNotes.rst (original)
+++ cfe/trunk/docs/ReleaseNotes.rst Fri Oct  6 14:02:28 2017
@@ -89,6 +89,11 @@ Non-comprehensive list of changes in thi
 - Bitrig OS was merged back into OpenBSD, so Bitrig support has been
   removed from Clang/LLVM.
 
+- The default value of _MSC_VER was raised from 1800 to 1911, making it
+  compatible with the Visual Studio 2015 and 2017 C++ standard library headers.
+  Users should generally expect this to be regularly raised to match the most
+  recently released version of the Visual C++ compiler.
+
 New Compiler Flags
 ------------------
 

Modified: cfe/trunk/lib/Driver/ToolChains/MSVC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/MSVC.cpp?rev=315107&r1=315106&r2=315107&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/ToolChains/MSVC.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains/MSVC.cpp Fri Oct  6 14:02:28 2017
@@ -1266,9 +1266,8 @@ VersionTuple MSVCToolChain::computeMSVCV
   if (MSVT.empty() &&
       Args.hasFlag(options::OPT_fms_extensions, options::OPT_fno_ms_extensions,
                    IsWindowsMSVC)) {
-    // -fms-compatibility-version=18.00 is default.
-    // FIXME: Consider bumping this to 19 (MSVC2015) soon.
-    MSVT = VersionTuple(18);
+    // -fms-compatibility-version=19.11 is default, aka 2017
+    MSVT = VersionTuple(19, 11);
   }
   return MSVT;
 }




More information about the cfe-commits mailing list