[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

Erik Verbruggen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 6 06:30:50 PDT 2017


erikjv added a comment.

lgtm, but someone else will probably have to review it too.



================
Comment at: lib/Parse/ParseDeclCXX.cpp:3196
   if (Tok.is(tok::colon)) {
+    ParseScope ClassScope(this, Scope::ClassScope|Scope::DeclScope | Scope::ClassInheritanceScope);
+
----------------
InheritanceScope instead of ClassScope? I mean, it's not really the scope of the class, that would be inside the class decl.
Also, clang-format this line.


https://reviews.llvm.org/D38618





More information about the cfe-commits mailing list