[PATCH] D38525: Cleanup and generalize -shared-libasan.

[Vitaly Buka via Phabricator via cfe-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/SanitizerArgs.cpp:614
+  if (Arg *A = Args.getLastArg(options::OPT_shared_libsan,
+                               options::OPT_static_libsan))
+    SharedRuntime = A->getOption().matches(options::OPT_shared_libsan);
----------------
```
SharedRuntime = Args.hasFlag(options::OPT_shared_libsan,,
                     options::OPT_static_libsan,
                     TC.getTriple().isAndroid() || TC.getTriple().isOSFuchsia());
```


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:563
+    if (SanArgs.needsUbsanRt()) {
+      if (SanArgs.requiresMinimalRuntime()) {
+        SharedRuntimes.push_back("ubsan_minimal");
----------------
Shouldn't ubsan changes be in the separate patch?


https://reviews.llvm.org/D38525