[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

In https://reviews.llvm.org/D35082#889053, @rjmccall wrote:

> Are you sure it's a good idea to not print the address space when it's implicit?  Won't that often lead to really confusing diagnostics?
>
> Also, we do already have a way of expressing that an extended qualifier was explicit: AttributedType.  We have very similar sorts of superficial well-formedness checks to what I think you're trying to do in ObjC ARC.


Based on my observation, in most cases it is OK not to print the implicit address space, and printing implicit address space could cause quite annoying cluttering. In some cases printing implicit address space may be desired. I can improve the printing in some future patch, e.g. only hide the implicit address space in situations which causes cluttering but not providing much useful information.

I think AttributedType sounds an interesting idea and worth exploring.

I just felt this review dragged too long (~ 3 months) already. We have an important backend change depending on this feature. Since the current solution achieves its goals already, can we leave re-implementing it by AttributedType for the future? Thanks.


https://reviews.llvm.org/D35082