[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list=<arg1, arg2, ...> to match gcc options.

[Hal Finkel via Phabricator via cfe-commits]

hfinkel added a comment.

In https://reviews.llvm.org/D37624#885438, @choikwa wrote:

> > Can you get more information on what GCC actually implemented and why? It's not clear to me that ignoring the namespaces is the most-useful way to do this. I don't want to emulate GCC bugs, but maybe there's a good reason why their implementation works this way.
>
> This is what I found, https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00473.html


To state the obvious, that patch has zero C++ test cases. Can try emailing the author of the feature in GCC and try to get some clarity on what the intended behavior is on their end? I'm trying to figure out what's useful here. I think we do want to match namespaces.

> Diff shows it doesn't seem to specially treat single quotes.
> 
> +    case OPT_finstrument_functions_include_function_list_:
>  +      add_comma_separated_to_vector
>  +	(&opts->x_flag_instrument_functions_include_functions, arg);
>  +      break;




https://reviews.llvm.org/D37624