[PATCH] D38048: [clangd] Add textDocument/signatureHelp

Raoul Wols via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 2 14:57:27 PDT 2017


rwols updated this revision to Diff 117427.
rwols added a comment.

- Update `invokeCodeComplete` function to also take a `CodeCompleteOptions`, we assign it to the `CompilerInstance`'s `FrontendOpts.CodeCompleteOpts`.
- Remove unused variable in `SignatureHelpCollector::ProcessOverloadCandidate`.


https://reviews.llvm.org/D38048

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdLSPServer.h
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  clangd/ClangdUnit.cpp
  clangd/ClangdUnit.h
  clangd/Protocol.cpp
  clangd/Protocol.h
  clangd/ProtocolHandlers.cpp
  clangd/ProtocolHandlers.h
  test/clangd/formatting.test
  test/clangd/initialize-params-invalid.test
  test/clangd/initialize-params.test
  test/clangd/signature-help.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38048.117427.patch
Type: text/x-patch
Size: 30982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171002/50f26998/attachment-0001.bin>


More information about the cfe-commits mailing list