[PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

George Karpenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 2 11:04:34 PDT 2017


george.karpenkov added a comment.

> breaking stand-alone builds as a result

That's a strong statement. Could you clarify? We have a lot of buildbots performing standalone builds, and they are still green.

> and the likeliness of people mistakenly adding more unconditional dependencies

That's a good point, however I'm not sure how your change would fix the problem.
As far as I remember targets in compiler-rt had quite a few dependencies which required checking for whether it is a standalone build.

In general, I'm not sure what this change would achieve, and the added complexity can always cause more bugs in the future.


Repository:
  rL LLVM

https://reviews.llvm.org/D38444





More information about the cfe-commits mailing list