[PATCH] D37677: [libc++] implement future synchronization using atomic_flag

Dennis Luxen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 2 02:53:52 PDT 2017


dennis.luxen planned changes to this revision.
dennis.luxen added a comment.

In https://reviews.llvm.org/D37677#868851, @EricWF wrote:

> I agree with the general consensus that we should only make this change if it's significantly faster, and only after we have a test that demonstrates this.
>
> Unfortunately I don't recall exactly why I wrote that TODO in the first place, but I'm sure I meant changing `__state_`, and not the lock. I suspect it had to do with http://llvm.org/PR24692 .


I talked to Marshall during CPPCon and he mentioned that the remark to use atomic was related to using `std::call_once`. I will rework this patch and use the defines from `__config` to mark it as an ABI breaking change.


https://reviews.llvm.org/D37677





More information about the cfe-commits mailing list