[PATCH] D38414: [clangd] simplify ClangdLSPServer by private-inheriting callback interfaces. NFC

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clangd/ClangdLSPServer.h:41
 private:
-  class LSPProtocolCallbacks;
-  class LSPDiagnosticsConsumer : public DiagnosticsConsumer {
-  public:
-    LSPDiagnosticsConsumer(ClangdLSPServer &Server);
-
-    virtual void
-    onDiagnosticsReady(PathRef File,
-                       Tagged<std::vector<DiagWithFixIts>> Diagnostics);
-
-  private:
-    ClangdLSPServer &Server;
-  };
+  // DiagnosticsConsumer
+  virtual void
----------------
NIT: Missing full stop at the end of the comment.


================
Comment at: clangd/ClangdLSPServer.h:46
+
+  // ProtocolCallbacks
+  void onInitialize(StringRef ID, InitializeParams IP,
----------------
NIT: Missing full stop at the end of the comment.


https://reviews.llvm.org/D38414