[PATCH] D38380: [libunwind] Add CMake support for building for MinGW

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.


================
Comment at: cmake/config-ix.cmake:38
+    else ()
+      set(MINGW_RUNTIME gcc_s gcc)
+    endif()
----------------
compnerd wrote:
> This seems really weird.  `gcc_s` and `gcc` are the same library, the former is the shared version of the latter.  Is this really correct?
I think so; my impression is that `libgcc.a` contains some object files that end up linked into every module, even if you're otherwise using a shared `libgcc_s_<ehmode>.dll`.

In any case, this is identical to the same lines in libcxxabi and libcxx as well; the only difference is in the library name above in `if (<libname>_USE_COMPILER_RT)`, so if there needs to be a change, it should be changed there as well.


https://reviews.llvm.org/D38380