[PATCH] D37905: [libclang, bindings]: add spelling location

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 28 20:19:47 PDT 2017

compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.

Comment at: bindings/python/clang/cindex.py:320
+        return self._get_spelling()['offset']
     def __eq__(self, other):
frutiger wrote:
> compnerd wrote:
> > Does it make sense to introduce two new properties `expansion` and `spelling` and have the four fields be properties on those properties?  It seems like it would be more pythonic.
> I agree, but I was concerned about breaking existing users that might be using the expansion properties directly on this object.  Would marking them deprecated in the documentation suffice?
Yeah, I think thats a great approach.


More information about the cfe-commits mailing list