[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 28 09:04:54 PDT 2017

ilya-biryukov added inline comments.

Comment at: clangd/GlobalCompilationDatabase.cpp:82
     // FIXME(ibiryukov): Invalidate cached compilation databases on changes
+    return Result;
Why remove this `FIXME`?

Comment at: clangd/tool/ClangdMain.cpp:86
+                    "The argument will be "
+                    "ignored.\n";
+    CompileCommandsDirPath = llvm::None;
NIT: maybe join this with previous line?

Comment at: clangd/tool/ClangdMain.cpp:89
+  } else
+    CompileCommandsDirPath = CompileCommandsDir;
NIT: don't mix branches with and without `{}`. Simply use `{}` on all branches in that case.


More information about the cfe-commits mailing list