[PATCH] D37905: [libclang, bindings]: add spelling location
Saleem Abdulrasool via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 27 21:28:14 PDT 2017
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
If I'm not mistaken, the change just means that the python bindings need a "newer" libclang, libclang's interfaces don't really change. I think that is acceptable.
Comment at: bindings/python/clang/cindex.py:320
+ return self._get_spelling()['offset']
def __eq__(self, other):
Does it make sense to introduce two new properties `expansion` and `spelling` and have the four fields be properties on those properties? It seems like it would be more pythonic.
Comment at: tools/libclang/CXSourceLocation.cpp:321
// FIXME: This should call SourceManager::getSpellingLoc().
+ SourceLocation SpellLoc = SM.getSpellingLoc(Loc);
Remove the FIXME please.
More information about the cfe-commits