[PATCH] D38270: [clang] Add getUnsignedPointerDiffType method

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 27 12:50:14 PDT 2017


aaron.ballman added a comment.

> The code for printf diagnostics + new tests are supposed to be added by a separate diff.

I think you should combine that diff and this one into a single patch, otherwise this patch is untestable.



================
Comment at: include/clang/AST/ASTContext.h:1492-1493
 
+  /// \brief Return the unique unsigned counterpart of 
+  /// "ptrdiff_t" integer type.
+  QualType getUnsignedPointerDiffType() const;
----------------
Wrap the comment, and you might want to refer to C11 7.21.6.1p7 as a justification for why this is needed.


Repository:
  rL LLVM

https://reviews.llvm.org/D38270





More information about the cfe-commits mailing list