[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 27 08:53:37 PDT 2017

ilya-biryukov added a comment.

I think your change makes sense, but maybe asking for a better description.

It appears you:

- Enabled crash recovery for some libclang operations on a calling thread even when `LIBCLANG_NOTHREAD` is specified.  Previously it would only run under crash recovery if `LIBCLANG_NOTHREAD` is not set.
- Moved handling of `LIBCLANG_NOTHREAD` env variable into `RunSafely` from its call sites.

That said, I am not familiar with the code you're changing, so can't really LGTM this. Hopefully, someone else can do that.


More information about the cfe-commits mailing list