[PATCH] D37436: Initial implementation of C attributes (WG14 N2137)

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 26 15:31:29 PDT 2017

aaron.ballman added a comment.

In https://reviews.llvm.org/D37436#871117, @aaron.ballman wrote:

> Updated based on review feedback.
> - Rename CAttributes to DoubleSquareBracketAttributes
> - Added Objective-C test cases to demonstrate no regressed behavior (based on a use-case pointed out during review)
> - Fixed regression with GNU-style attributes in enumerations
>   I still need to rename the cc1 flag, pending agreement on the name.

Ping -- the last outstanding issue that I'm aware of is the cc1 flag name, do you have a preference there, Richard? If not, I'll be going with the verbose `-fdouble-square-bracket-attributes`.


More information about the cfe-commits mailing list