[PATCH] D38032: [clangd] Serialize onDiagnosticsReady callbacks for the same file.

[Manuel Klimek via Phabricator via cfe-commits]

klimek added inline comments.


================
Comment at: clangd/ClangdServer.cpp:321-324
+    // FIXME(ibiryukov): get rid of '<' comparison here. In the current
+    // implementation diagnostics will not be reported after version counters'
+    // overflow. This should not happen in practice, since DocVersion is a
+    // 64-bit unsigned integer.
----------------
Why is this a FIXME? Do we intend to use a different mechanism? 2^64 versions of a file seem to be a lot?


================
Comment at: unittests/clangd/ClangdTests.cpp:912
+        StartSecondReparse.set_value();
+        // Sleep long enough for the second request to be processed.
+        std::this_thread::sleep_for(std::chrono::milliseconds(50));
----------------
Why not hand in a signal to wait for?


https://reviews.llvm.org/D38032